Make sure RepeatTeacher doesn't leak files. #1225

stephenroller · 2018-10-17T17:24:03Z

Right now, running the unittest suite results in a leaking file unused_paths.lengths. This behavior derives from:

Line 46 in 5899c07

task='tasks.repeat:RepeatTeacher:10',

Lines 16 to 26 in 5899c07

    
           class RepeatTeacher(DialogTeacher): 
        
               def __init__(self, opt, shared=None): 
        
                   opt = copy.deepcopy(opt) 
        
                   opt['datafile'] = 'unused_path' 
        
                   task = opt.get('task', 'tests.tasks.repeat:RepeatTeacher:50') 
        
                   self.data_length = int(task.split(':')[2]) 
        
                   super().__init__(opt, shared) 
        
               def setup_data(self, unused_path): 
        
                   for i in range(self.data_length): 
        
                       yield ((str(i), [str(i)]), True)

ParlAI/parlai/core/teachers.py

Line 814 in 5899c07

length_file = datafiles[0] + ".lengths"

Make sure RepeatTeacher doesn't leak files.

85db905

stephenroller requested a review from emilydinan October 17, 2018 17:24

facebook-github-bot added the CLA Signed label Oct 17, 2018

alexholdenmiller approved these changes Oct 17, 2018

View reviewed changes

stephenroller merged commit 9441144 into master Oct 17, 2018

stephenroller deleted the quietrepeat branch October 17, 2018 20:05

This was referenced Jun 20, 2023

[Snyk] Security upgrade webpack-cli from 3.3.12 to 4.0.0 javakian/ParlAI#91

Open

[Snyk] Security upgrade webpack-cli from 3.3.12 to 4.0.0 javakian/ParlAI#97

Open

[Snyk] Fix for 1 vulnerabilities javakian/ParlAI#101

Open

javakian mentioned this pull request May 14, 2024

[Snyk] Fix for 2 vulnerabilities javakian/ParlAI#174

Open

This was referenced May 14, 2024

[Snyk] Fix for 2 vulnerabilities javakian/ParlAI#175

Open

[Snyk] Fix for 2 vulnerabilities javakian/ParlAI#176

Open

[Snyk] Fix for 2 vulnerabilities javakian/ParlAI#177

Open

[Snyk] Fix for 2 vulnerabilities javakian/ParlAI#178

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure RepeatTeacher doesn't leak files. #1225

Make sure RepeatTeacher doesn't leak files. #1225

stephenroller commented Oct 17, 2018

	class RepeatTeacher(DialogTeacher):
	def __init__(self, opt, shared=None):
	opt = copy.deepcopy(opt)
	opt['datafile'] = 'unused_path'
	task = opt.get('task', 'tests.tasks.repeat:RepeatTeacher:50')
	self.data_length = int(task.split(':')[2])
	super().__init__(opt, shared)

	def setup_data(self, unused_path):
	for i in range(self.data_length):
	yield ((str(i), [str(i)]), True)

Make sure RepeatTeacher doesn't leak files. #1225

Make sure RepeatTeacher doesn't leak files. #1225

Conversation

stephenroller commented Oct 17, 2018